Fix sub-group 'of' tests #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered/discussed in KhronosGroup#795, the `predicate_function_of_sub_group` test was using the global linear ID to perform sub-group 'of' checks. The checks were only being run on the first sub-group (with ID 0). This was implicitly relying on the first sub-group containing the work-items with IDs from 0 up to the sub-group size, as the checks included conditions like exactly one ID being 1. This is not correct in general, as the mapping between work-items and sub-group items is not defined. In addition, this commit also enhances the sub-group tests to check that *all* sub-groups in the work-group return the correct result. Before we were either checking only the *first* sub-group (`predicate_function_of_sub_group`) or checking all sub-groups but overwriting the results each time, so in effect only checking the *last* sub-group. Now the results are initialized to 'true' and each sub-group is run and its results are merged with all of the other results.
|
That sounds good. Probably apply some of #804 (comment) |
bader
approved these changes
Oct 11, 2023
I've added some extra comments now. I'm not sure exactly what suggestions you were making, so hopefully this is what you had in mind. |
Co-authored-by: Ronan Keryell <[email protected]>
|
I don't suppose someone would be able/willing to squash this branch when merging? It's become a little messy (at least to my mind). No worries either way, though. |
keryell
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered/discussed in
#795, the
predicate_function_of_sub_grouptest was using the global linear ID to perform sub-group 'of' checks.The checks were only being run on the first sub-group (with ID 0). This was implicitly relying on the first sub-group containing the work-items with IDs from 0 up to the sub-group size, as the checks included conditions like exactly one ID being 1. This is not correct in general, as the mapping between work-items and sub-group items is not defined.
In addition, this commit also enhances the sub-group tests to check that all sub-groups in the work-group return the correct result. Before we were either checking only the first sub-group
(
predicate_function_of_sub_group) or checking all sub-groups but overwriting the results each time, so in effect only checking the last sub-group.Now the results are initialized to 'true' and each sub-group is run and its results are merged with all of the other results.