Using vector<unsigned char> instead of vector<bool>

[ChengChen002]

Since the std::vector<bool> type does not have a data() member function,
Using vector instead of vector.

[ChengChen002]

I haven't come up with a cleaner way to fix this yet, please comment if you have any other suggestions! Thanks.

[bader]

I haven't come up with a cleaner way to fix this yet, please comment if you have any other suggestions! Thanks.

Please, push "Ready for review" button if you want this PR to be reviewed.

[keryell]

This looks correct but there is a lot of code duplication.
I was thinking about introducing a generic container type that would select either a std::vector or a std::array according to the value type, but thinking again, why not just using always a std::array?

[ChengChen002]

This looks correct but there is a lot of code duplication. I was thinking about introducing a generic container type that would select either a std::vector or a std::array according to the value type, but thinking again, why not just using always a std::array?

This is to avoid using too much stack memory, you can see more information in #823.

[keryell]

Thanks! I love shorter code for maintenance. :-)

[keryell]

Thanks!