Test marray on device #854
Conversation
This commit makes marray tests run checks on both device and host, where they would only run on host previously. Signed-off-by: Larsen, Steffen <[email protected]>
| // default constructor | ||
| { | ||
| marray_t ma; | ||
| CHECK(value_operations::are_equal(ma, DataT{})); | ||
| *(results++) = value_operations::are_equal(ma, DataT{}); |
There was a problem hiding this comment.
() are redundant but it might be clearer too. So no problem.
There was a problem hiding this comment.
You are absolutely right, but since they are unary operators on each side of the expression I think it's one of those cases where the precedence rules get hard to remember, so I personally prefer the parenthesis. 😄
|
|
||
| // only compiled when NumElements != 1 | ||
| check_constexpr_single_element(); | ||
| if constexpr (NumElements != 1) { |
There was a problem hiding this comment.
These test cases try to construct an marray using a scalar and an marray of size NumElements - 1. If NumElements is 1, then the smaller marray would have to be of size 0. 0-sized marrays are not allowed by the specification based on the following:
The number of elements parameter, NumElements, is a positive value of the std::size_t type.
There was a problem hiding this comment.
Oh I see, by looking at the called function.
You just implement the comment, actually. :-)
This commit makes marray tests run checks on both device and host, where they would only run on host previously. Additionally it splits operator tests up in separate categories to reduce compilation overhead.
Fixes #821