Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Drop code related to error_category_for #857

Conversation

AlexeySachkov
Copy link
Contributor

That API was removed from the SYCL 2020 specification in KhronosGroup/SYCL-Docs#431

@AlexeySachkov AlexeySachkov marked this pull request as ready for review January 20, 2024 09:14
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner January 20, 2024 09:14
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I am unsure this is really [NFC] as you are removing some functionality.

@AlexeySachkov
Copy link
Contributor Author

Thanks. I am unsure this is really [NFC] as you are removing some functionality.

As you can see, I've only changed a single file which defined those "helpers" - that means that they have never been in use and that was essentially a dead code. In that case this probably satisfies [NFC] tag.

Note: I'm fine with the tag removal. I can do that myself, or it can be done by a maintainer if squash strategy is used when accepting the PR. Second note: without squash on accept, removal of the tag from the existing commit will require rebase and force-push from my side

@bader
Copy link
Contributor

bader commented Jan 25, 2024

We use merge strategy in this repository.

Thanks. I am unsure this is really [NFC] as you are removing some functionality.

As you can see, I've only changed a single file which defined those "helpers" - that means that they have never been in use and that was essentially a dead code. In that case this probably satisfies [NFC] tag.

I'm fine merging with existing PR title. @keryell?

@tomdeakin tomdeakin merged commit f843993 into KhronosGroup:SYCL-2020 Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants