Fix errors for some spec_constants tests when running in AOT mode #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hu, Peisen <[email protected]>
bader
reviewed
Feb 14, 2024
Signed-off-by: Hu, Peisen <[email protected]>
bader
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let these spec_constants tests skip validation when no target kernel is available to make them pass in AOT mode (since no input state bundles will be available under AOT mode). Previously they do validate the results despite printing log statements like "kernel_bundle doesn't contain target kernel ... (skipped)", which cause these tests to fail unexpectedly when running under AOT mode.
Below is a listed of the affected (i.e. fixed) test cases:
specialization_constants_defined_various_ways_via_kb_core
specialization_constants_defined_various_ways_via_kb_fp16
specialization_constants_defined_various_ways_via_kb_fp64
specialization_constants_multiple_via_kb_core
specialization_constants_multiple_via_kb_fp16
specialization_constants_multiple_via_kb_fp64
specialization_constants_same_name_inter_link_1st_tu_via_kb_core
specialization_constants_same_name_inter_link_1st_tu_via_kb_fp16
specialization_constants_same_name_inter_link_1st_tu_via_kb_fp64
specialization_constants_same_name_inter_link_2nd_tu_via_kb_core
specialization_constants_same_name_inter_link_2nd_tu_via_kb_fp16
specialization_constants_same_name_inter_link_2nd_tu_via_kb_fp64
specialization_constants_same_name_stress_via_kb_core
specialization_constants_same_name_stress_via_kb_fp16
specialization_constants_same_name_stress_via_kb_fp64