expression: fix incorrect copy of flag in truncate function (pingcap#…

…55284) close pingcap#53546
King-Dylan · Nov 15, 2024 · 4272a56 · 4272a56
1 parent 938ed70
commit 4272a56
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/pkg/expression/builtin_math.go b/pkg/expression/builtin_math.go
@@ -2047,7 +2047,10 @@ func (c *truncateFunctionClass) getFunction(ctx BuildContext, args []Expression)
 		bf.tp.SetDecimalUnderLimit(calculateDecimal4RoundAndTruncate(ctx, args, argTp))
 		bf.tp.SetFlenUnderLimit(args[0].GetType(ctx.GetEvalCtx()).GetFlen() - args[0].GetType(ctx.GetEvalCtx()).GetDecimal() + bf.tp.GetDecimal())
 	}
-	bf.tp.AddFlag(args[0].GetType(ctx.GetEvalCtx()).GetFlag())
+	argFieldTp := args[0].GetType(ctx.GetEvalCtx())
+	if mysql.HasUnsignedFlag(argFieldTp.GetFlag()) {
+		bf.tp.AddFlag(mysql.UnsignedFlag)
+	}
 
 	var sig builtinFunc
 	switch argTp {

diff --git a/tests/integrationtest/r/expression/constant_fold.result b/tests/integrationtest/r/expression/constant_fold.result
@@ -24,3 +24,9 @@ utf8mb4_general_ci
 select collation(ifnull(concat(NULL),ifnull(concat(NULL),id))) from t1;
 collation(ifnull(concat(NULL),ifnull(concat(NULL),id)))
 utf8mb4_general_ci
+drop table if exists t1;
+create table t1 (c1 int);
+insert into t1 values (null);
+select truncate(1,c1), truncate(1,c1) is not NULL from t1;
+truncate(1,c1)	truncate(1,c1) is not NULL
+NULL	0
diff --git a/tests/integrationtest/t/expression/constant_fold.test b/tests/integrationtest/t/expression/constant_fold.test
@@ -11,3 +11,9 @@ select collation(ifnull(concat(NULL),ifnull(concat(id),'~'))) from t;
 select collation(ifnull(concat(id),ifnull(concat(id),'~'))) from t;
 select collation(ifnull(concat(NULL),id)) from t1;
 select collation(ifnull(concat(NULL),ifnull(concat(NULL),id))) from t1;
+
+# https://github.com/pingcap/tidb/issues/53546
+drop table if exists t1;
+create table t1 (c1 int);
+insert into t1 values (null);
+select truncate(1,c1), truncate(1,c1) is not NULL from t1;