Update test_mixed_electrolyte_activity.py #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the revised values and the command "from pyeql import solutions" for the test to go through
Jaebeom-P
reviewed
Feb 19, 2025
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| import pyEQL | |||
|
|
|||
| from pyEQL import Solution | |||
There was a problem hiding this comment.
Can remove this part (unnecessary)
There was a problem hiding this comment.
Ok, I added it when I attempted to run the pytest in VScode
Jaebeom-P
reviewed
Feb 19, 2025
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| import pyEQL | |||
|
|
|||
| from pyEQL import Solution | |||
|
|
|||
| # relative tolerance between experimental and computed properties for this test file | |||
| RTOL = 0.25 | |||
There was a problem hiding this comment.
Will work with RTOL value over 0.45
|
Thanks for the assist @Jaebeom-P . I'm closing this one because the latest changes are in #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the revised values and the command "from pyeql import solutions" for the test to go through
Summary
Major changes:
Todos
If this is work in progress, what else needs to be done?
Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.Tip: Install
pre-commithooks to auto-check types and linting before every commit: