Using std::string::string #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code utilizes class ctor, not `operator=` and was broken by sdbus-cpp 2.0.0: ``` const sdbus::ObjectPath SIGNALQ_DBUS_NOTIFY_MGR_OBJ_PATH = "/signalq/notify_mgr"; ``` This fixes the behavior.
|
This was intentional breaking change. I guess you realized that yourself after opening the MR and closed the MR subsequently :-) |
|
I realized that this PR breaked the build though I did not find the way to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code utilizes class ctor, not
operator=and was broken by sdbus-cpp 2.0.0:This fixes the behavior.