Add support for lifespan state #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Sep 20, 2024
|
@FurqanHabibi Would you like to rebase this? 🙏 |
|
@Kludex Rebased it 🙏 |
|
@FurqanHabibi GitHub gets a bit hard to work on when you don't create branches on your fork (when you commit directly to main). I don't know how to push to this branch... 🤷♂️ |
|
I'll be merging this: #337, but I'll maintain your commits there. Thanks for the contribution. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323
The lifespan state is created in lifespan cycle, and a shallow copy is passed in http cycle.
Also added test to confirm the functionality.
Note that a sub-dependency
Hypercornneed to be pinned to support testing on python 3.7.