feat: expose request.get_raw_path #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with Kong/kong#14338 and the change introduced in Kong/kong#8823
This pull request includes updates to the
requestpackage to add a new method for retrieving the raw, non-normalized version of the request path. Additionally, it includes updates to the corresponding tests and protocol definitions.Additions and Updates to Request Methods:
request/request.go: Added a new methodGetRawPath()which returns the raw, non-normalized version of the request path. Updated the comments forGetPath()to clarify that it returns the normalized path component.Updates to Tests:
request/request_test.go: Added test cases for the newGetRawPath()method to ensure it returns the expected raw path. [1] [2]Protocol Definition Updates:
server/kong_plugin_protocol/pluginsocket.proto: AddedRequest_GetRawPathto the protocol definitions to support the new method.