Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add go.mime function as replacement for kong.tools.mime_type #56

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

GGabriele
Copy link
Contributor

No description provided.

@GGabriele GGabriele requested a review from a team as a code owner October 5, 2023 15:50
@GGabriele GGabriele requested a review from mikefero October 5, 2023 15:50
mikefero
mikefero previously approved these changes Oct 11, 2023
Copy link
Contributor

@mikefero mikefero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment and it is completely up to you if you think we should change it.

Nice work!!!

end

return {
name = "request-validator-simplified",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about changing this filename to request-validator-mime.lua and the name to request-validator-mime since we are just validating the mime types and not actually the full request-validator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! fe35947

@GGabriele GGabriele merged commit e9156a3 into main Oct 11, 2023
@GGabriele GGabriele deleted the feat/add-mime-function branch October 11, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants