Skip to content

Commit

Permalink
fix(httpie): do not fail the build if httpie fails to install
Browse files Browse the repository at this point in the history
Failures can happen if pip.conf isn't available and security settings
like proxies are required. Now we will just skip the install.
  • Loading branch information
Tieske committed Jan 29, 2024
1 parent 21a4afd commit 1679069
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@

## unreleased

* Fix: do not fail the build if httpie cannot be installed. Now continues the
build since it is optional.
[#515](https://github.com/Kong/kong-pongo/pull/515).

* Fix: the --debug option will now output full buildlogs again using buildkit
[#513](https://github.com/Kong/kong-pongo/pull/513).

Expand Down
2 changes: 1 addition & 1 deletion assets/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ ARG ftp_proxy
RUN apt update \
&& apt install -y zip make jq m4 curl build-essential wget git libssl-dev zlib1g-dev lsb-release psmisc net-tools
RUN /pongo/install-python.sh
RUN pip3 install httpie
RUN pip3 install httpie || echo -e "\n\n\nFailed installing httpie, continuing without.\n\n\n"
RUN curl -k -s -S -L https://github.com/fullstorydev/grpcurl/releases/download/v1.7.0/grpcurl_1.7.0_linux_x86_64.tar.gz | tar xz -C /kong/bin
RUN cd /kong \
&& git config --global url.https://github.com/.insteadOf git://github.com/ \
Expand Down

0 comments on commit 1679069

Please sign in to comment.