feat: add custom ca certificate support for pongo image #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've only tested on macOS, should try e.g. WSL2, ubuntu, amzn... |
|
Oh it's failing all code coverage also |
Tieske
requested changes
Nov 5, 2024
| PONGO_CUSTOM_CA_CERT | ||
| set this to the absolute path of a custom CA to add to the | ||
| container's truststore | ||
|
|
There was a problem hiding this comment.
Since this is added in the container build, I think this should go in the help-docs of the pongo build command.
| For example: | ||
|
|
||
| ```sh | ||
| $ PONGO_CUSTOM_CA_CERT="$(pwd)/zscaler-root.crt" pongo up |
There was a problem hiding this comment.
this is a bad example I think, though it would probably work if the container image still needs to be build.
So I think the example should have 2 commands;
- the build command including the flag for CA certs
- the run command without the flags (to indicate clearly they are in the image)
| msg "custom CA is set: $PONGO_CUSTOM_CA_CERT" | ||
| cp "$PONGO_CUSTOM_CA_CERT" "$LOCAL_PATH/custom_ca.crt" | ||
| else | ||
| echo -n '' > "$LOCAL_PATH/custom_ca.crt" |
There was a problem hiding this comment.
can't we add it in some less visisble location?
|
@tysoekong wdyt; should the cert be added in the build stage (and become part of the created image), or should it be added while doing a pongo run/shell? (eg. upon container instantiation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows pongo to add a custom CA into the container image's OS truststore during the build/up.
It allows the user to add e.g. their employer's traffic inspection CA.
It makes these all works, when running behind e.g. Zscaler: