Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update/1 on a missing guild should not crash #628

Merged
merged 1 commit into from
Aug 17, 2024
Merged

update/1 on a missing guild should not crash #628

merged 1 commit into from
Aug 17, 2024

Conversation

Th3-M4jor
Copy link
Contributor

There was an inconsistency between the ETS and Mnesia implementations where the ETS one would crash on an update/1 if the guild did not currently exist in the cache while the Mnesia one would return normally.

jchristgit
jchristgit approved these changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jchristgit jchristgit merged commit 4179b3a into Kraigie:master Aug 17, 2024
10 checks passed
@jchristgit
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Th3-M4jor @jchristgit