Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception handling #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add exception handling #15

wants to merge 1 commit into from

Conversation

zenolus
Copy link
Contributor

@zenolus zenolus commented Dec 10, 2019 •
edited
Loading

Added exception handling support for

  1. Invalid user handle
  2. Failed GET request for problemset_data
  3. Display error message for any other error

Krythz43
Krythz43 requested changes Dec 11, 2019
View reviewed changes
Copy link
Owner

@Krythz43 Krythz43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always a good practice to leave-in proper messages while sending PRs. I know this is minor, but do edit it.

@zenolus
Copy link
Contributor Author

zenolus commented Dec 11, 2019

Updated

@zenolus zenolus requested a review from Krythz43 December 11, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krythz43 Krythz43 Awaiting requested review from Krythz43

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenolus @Krythz43