-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds photo support #126
base: main
Are you sure you want to change the base?
Adds photo support #126
Conversation
Hey @agsalguero, thanks so much for the contributions! I'll try to review all until this weekend, I just want to ask 2 points beforehand:
|
I have added an option in preferences to enable the "extended" version of quickcut buttons for both photos and videos. The default list is now [1, 2, 3, 5, 10] while the extended version is [1, 1.5, 2, 3, 4, 5, 6, 7, 8, 9, 10]. Change those values as you want but please keep 1.5 value, as it is the duration of favourite videos in the app (most of) us came from ;-). IMPORTANT: in order for this PR to work you will also need to accept the PR for the video_trimmer subproject (KyleKun/video_trimmer#1) I send some days ago, since the list of quickcut durations is now passed as an optional parameter. Edit: I've not tested the vertical mode but there might be some conflicts since the ffmpeg command is also altered. I'll review the code once the other PR is accepted. |
@KyleKun |
Will do sir 🫡 |
Great to see you again! Please note that:
|
Description
Create videos from photos.
Checklist
CHANGELOG.md
.CONTRIBUTORS.md
file, if it wasn't already present.