-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Modified h5 reader for LASY #361
Open
Paaaaarth
wants to merge
16
commits into
LASY-org:development
Choose a base branch
from
Paaaaarth:read_openpmd
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This is still WIP, right? |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
lasy
package, particularly focusing on the handling of OpenPMD profiles and improvements to thecreate_grid
function. The changes aim to enhance functionality and improve code clarity.Updates to OpenPMD Profile Handling:
lasy/profiles/from_openpmd_profile.py
: Removed the dependency onOpenPMDTimeSeries
and replaced it with direct usage ofopenpmd_api
. This change simplifies the process of reading laser field data from OpenPMD files.lasy/profiles/from_openpmd_profile.py
: Refactored theFromOpenPMDProfile
class to remove unused parameters and streamline the initialization process. The class now directly reads data usingopenpmd_api
and handles different field dimensions ('rt' and 'xyt').Improvements to Utility Functions:
lasy/utils/laser_utils.py
: Modified thecreate_grid
function to usenp.allclose
instead ofnp.all
for comparing grid axes. This change ensures that the comparisons are tolerant to small numerical differences, improving robustness.Available functionality: