Ability to apply user-defined photon emission region added #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @szhang17phys (Shuaixiang) for develop. It involves the following packages: larsim @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
-code-checks Then commit the changes and push them to your PR branch. |
format-code made
|
Pull request #147 was updated. @LArSoft/level-2-managers, @LArSoft/level-1-managers can you please check and sign again. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the default variables fXmin, fXmax, etc to set the user-defined photon emission region. If these variables are not given new values by user, the module will set the values of these variables from the cryostat, i.e the default cryostat boundary. If user points values to these variables, user-defined variables will be taken.