-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for recorded source/mic directivities from DIRPAT database (#259) #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * This is a pretty big commit that includes loading recorded directivity files and using them in the simulation * Supports source/receiver for shoebox rooms * Interpolation in spherical harmonic domain * Adds option for using minimum phase filters --------- Co-authored-by: prerak23 <[email protected]>
5 tasks
…r the SOFA directivities. Adds samples some pre-generated samples for the tests. Removes some print statements from room.py.
…rical/cartesian conversion functions from doa sub-package. Adds a generalized pinv computation function. Adds a new plotting function. Moves doa sub-package fibonacci mapping to a dedicated function to make it available everywhere.
…ation. Adds also a generalized version of the method for the case where the measurement points are not on a grid. Adds tests for all this. Changes the regression test data files for sofa interpolation.
…s. Modifies slightly doa.GridSphere object so that it can be used to hold simple spherical grids without overhead.
…ore SOFA files. Fixes a bug with using cardioid/sofa responses where the cardioid would expect degrees, but got radians. Re-generates the test files for SOFA measured respones. Fixes a bug in DirectionVector where the degrees argument for the getter methods of azimuth and colatitude was ignored.
…naural simulation
… test for correctness based on the energy integral on the sphere.
…arate classes wrapper instead (Cardioid, Sub-cardioid, etc). Adds Rotation3D class to apply arbitrary rotations to measured directivities.
… to cartesian coordinates. Re-generates the test file after visual inspection.
prerak23
reviewed
Jun 13, 2024
prerak23
reviewed
Jun 13, 2024
prerak23
reviewed
Jun 13, 2024
prerak23
reviewed
Jun 13, 2024
prerak23
reviewed
Jun 13, 2024
…uding origin and license in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to integrate the work done by @prerak23 into the master branch:
Generalize for other SOFA files
The goal is to generalize what has been done for DIRPAT by @prerak23 to all SOFA files.
The target syntax is as follows.
TODO
get_response
that would return a(n_image_sources, n_channels, n_taps)
array.Co-authored-by: prerak23 [email protected]
Thanks for sending a pull request (PR), we really appreciate that! Before hitting the submit button, we'd be really glad if you could make sure all the following points have been cleared.
Please also refer to the doc on contributing for more details. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.
nosetests
orpy.test
at the root of the repo ?Happy PR 😃