add config for studying ecal resolution #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomeichlersmith
force-pushed
the
Ecal/trig-prim-study
branch
from
2486e69 to
06d9ce2
Compare
|
The If you need help with the TODO, there is somebody at UCSB who is looking for a project. This also means that it wont be done very quickly, so if it's urgent then maybe not the best thing to give him. |
|
Thanks 👍 I was being too quick with creating new branches! We already have a grad student here at UMN working on this (not sure on his GitHub username right now), so no need to give it to the UCSB student. |
tomeichlersmith
force-pushed
the
Ecal/trig-prim-study
branch
from
06d9ce2 to
b61c077
Compare
tomeichlersmith
commented
Jun 3, 2024
There was a problem hiding this comment.
Clean-Up To Dos Before Merge
- Rebase excluding ROOT files erroneously commited in earlier commits
- Add
*.rootfiles to.gitignore? Would need to check this doesn't break CI which relies on golden histogram ROOT files. - Documentation pass
- Promote compile-time constants to configuration parameters that copy from existing reco
metal004
force-pushed
the
Ecal/trig-prim-study
branch
from
a190f87 to
38ad6e5
Compare
This includes all of the changes from the prior branch but without the ROOT data files filling up the commit history. - two config scripts for generating different types of incident electron distributions into the ECal - a config for running the trig prim resolution analyzer over input data files - a new single-file trig prim resolution analyzer which fills histograms comparing different sums at the trigger level and full readout level
command: clang-format -i Ecal/src/Ecal/TrigPrimResolutionAnalyzer.cxx from with ldmx/dev container image
- promote compile-time constants to be configuration-possible class members - add doxygen-style comments to class and some important functions - remove code leftovers that were commented-out or not used for filling histograms - merge two loops over the same stuff together - producing *identical* histograms as previous version of code over 10 quick monoenergetic 4GeV events
tomeichlersmith
force-pushed
the
Ecal/trig-prim-study
branch
from
30aeead to
d142842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an re-opening of a submodule PR (LDMX-Software/Ecal#50) where I followed the instructions to re-apply my changes in one commit onto the subdirectory.
I am updating ldmx-sw, here are the details.
I've copied this config around for awhile so it is time to put it into the repository.
This config is focused on firing electrons directly into the ECal and then running the various processors that emulate electronics and reconstruct stuff within the ECal so users can then analyze the output.
To Do