-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just adopt a task runner #1380
just adopt a task runner #1380
Conversation
acc0f23
to
b119345
Compare
Another feature I'm missing is the autocomplete, with earlier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested most of the features, both on Linux and Mac. My most important ask is the autocomplete, the rest I could imagine life w/o....
You can enable and then you need to attach these autocomplete functions to the I can put the second one into the
so that they are auto-loaded by |
OK this works for me, I'm happy now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major changes requested are done (TS config file is still there, but I guess that's ok)
Edit: All good now! Thanks Tom!
patch check calls to be quiet and not run command partition justfile to have mimics of ldmx at bottom don't re-print just --list call fix mimics to only be one arg for image or dir draft a format function"
more notes and soup up some of the commands format requires space between recipes add some printouts with ansi coloring use a tempfile for listing c++ files to format add clean and test recipes
remove format short alias
also label features with just version requirement
start reworking readme tighten up listing of git requirement update links in readme comment about necessity of just add `just init` to list of startup commands for developers
this makes it operate a bit closer to the original ldmx bash function which didn't care about where it was run
7ad22ba
to
57ffa7c
Compare
…seeing deprecation warning
I am updating ldmx-sw by including a justfile and rewriting the README to point folks to
denv
andjust
. The ldmx-env.sh script is left in place and is only changed to include a deprecation notice if a user sources it and does not have bothdenv
andjust
installed. (If both are available, thenldmx
is just an alias forjust
and the justfile recipes are used instead of the ldmx-env.sh bash functions.)The best way to show why I chose this workflow is probably to show some examples assuming
denv
andjust
are installed.New Clone
Default Build
From somewhere else
Pretty Output
What are the issues that this addresses?
This resolves #1377 directly and resolves #1248 indirectly (via
denv
).Check List
rootbrowse
recipe androot
denv
and the production images allows many folks who are just using ldmx-sw to do studies to avoid compiling ldmx-sw themselves. I think this is a nice workflow since it both pins the version of ldmx-sw of the study and allows users to jump right in to a physics study without needing to run the compilation. This is a workflow change though and so I'd want to update the doc website to reflect this suggestion.denv
and create LDMX-Software forkdenv
has GUI support on MacOS (Unsure on GUI connection for non-Linux hosts tomeichlersmith/denv#80 -> Enable MacOS GUI Connection tomeichlersmith/denv#120), create a major stable version (v1), and create an LDMX-Software fork ofdenv
so that it can hang around with the collaboration separate from my personal account.After @tvami 's first review...
ldmx
symlink todenv
to allow folks used to theldmx
program to continue using it after transitionjust
toldmx
alias within ldmx-env.sh🛑 Won't Do 🛑
/cvmfs/unpacked.cern.ch
in environment script #1252 could be done within these recipes but I think it is too complicated to try to do on this first passfrom-ldmx-env
recipe. Thought about it, butdenv
pretty much requires the ldmx/dev image to be one of the newest available and other updates to ldmx-sw deprecate non-v4 images, so encouraging updating is a good way to go.