-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ldmx-sw versioning to dedicated file #1546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some other updates.
- We could move the reading of the VERSION file earlier in the CMake so that the CMake can be informed of the VERSION as well.
Right now, CMake thinks we are pretty old
Line 18 in b319599
project(LDMX_SW VERSION 3.1.1 |
Not sure if we can set the version with a variable value though.
- Update the function that prints the gold label to just dump this file.
ldmx-sw/.github/actions/common.sh
Line 25 in b319599
cat ${LDMX_GOLD_LABEL_FILE} |
- update to copy the VERSION along with the golds from trunk
run: git checkout origin/trunk -- .github/validation_samples/*/gold.root .github/actions/validate/gold_label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just trying to remove the gold_label so that it doesn't confuse anyone in the future. I think these are the necessary edits and then we can just git rm .github/actions/validate/gold_label
.
Co-authored-by: Tom Eichlersmith <[email protected]>
21018c6
to
5e43c86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last more cosmetic thing: we could update the patch number now to keep it consistent or just do another patch release to help test it.
Co-authored-by: Tom Eichlersmith <[email protected]>
I'll add the tracking to ecal veto next, we can cut a patch release after that which can also act as a test for this |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This is a follow up to #1539 (comment)
Check List
Locally this works, for github we are testing on the fly...