Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ldmx-sw versioning to dedicated file #1546

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

tvami
Copy link
Member

@tvami tvami commented Jan 29, 2025

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This is a follow up to #1539 (comment)

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

Locally this works, for github we are testing on the fly...

Sorry, something went wrong.

@tvami tvami requested a review from tomeichlersmith January 29, 2025 16:41
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some other updates.

  • We could move the reading of the VERSION file earlier in the CMake so that the CMake can be informed of the VERSION as well.
    Right now, CMake thinks we are pretty old

project(LDMX_SW VERSION 3.1.1

Not sure if we can set the version with a variable value though.

  • Update the function that prints the gold label to just dump this file.

cat ${LDMX_GOLD_LABEL_FILE}

  • update to copy the VERSION along with the golds from trunk

run: git checkout origin/trunk -- .github/validation_samples/*/gold.root .github/actions/validate/gold_label

Sorry, something went wrong.

@tvami tvami requested a review from tomeichlersmith January 29, 2025 18:03
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying to remove the gold_label so that it doesn't confuse anyone in the future. I think these are the necessary edits and then we can just git rm .github/actions/validate/gold_label.

@tvami tvami force-pushed the iss1538-persist-ldmxsw-version-v2 branch from 21018c6 to 5e43c86 Compare January 29, 2025 18:50
@tvami tvami marked this pull request as draft January 29, 2025 18:51
@tvami tvami marked this pull request as ready for review January 29, 2025 18:51
@tvami tvami requested a review from tomeichlersmith January 29, 2025 18:51
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last more cosmetic thing: we could update the patch number now to keep it consistent or just do another patch release to help test it.

tvami and others added 2 commits January 29, 2025 10:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Tom Eichlersmith <[email protected]>
@tvami
Copy link
Member Author

tvami commented Jan 29, 2025

just do another patch release to help test it.

I'll add the tracking to ecal veto next, we can cut a patch release after that which can also act as a test for this

@tvami tvami requested a review from danyi211 January 29, 2025 18:56
@tvami tvami merged commit 0783bd7 into trunk Jan 29, 2025
3 checks passed
@tvami tvami deleted the iss1538-persist-ldmxsw-version-v2 branch January 29, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants