Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment based PR validation #1556

Merged

Conversation

tvami
Copy link
Member

@tvami tvami commented Jan 31, 2025

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1555

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

@tvami tvami linked an issue Jan 31, 2025 that may be closed by this pull request
@tvami
Copy link
Member Author

tvami commented Jan 31, 2025

/run-validation

@tvami tvami marked this pull request as ready for review January 31, 2025 15:19
@tvami
Copy link
Member Author

tvami commented Jan 31, 2025

/run-validation

@tvami
Copy link
Member Author

tvami commented Jan 31, 2025

so maybe for this to work, we need to have it merged in the first place? @tomeichlersmith any thoughts?

@tvami tvami requested a review from tomeichlersmith January 31, 2025 15:24
@tomeichlersmith
Copy link
Member

Yes, only workflows on the default branch on GitHub are run.

@tvami tvami merged commit 8e20ddf into trunk Jan 31, 2025
0 of 9 checks passed
@tvami tvami deleted the iss1555-make-pr-validation-ci-triggerable-by-pr-comment branch January 31, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PR validation CI triggerable by PR comment
2 participants