-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor codec metadata and fill values #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 81.98% 81.91% -0.07%
==========================================
Files 177 179 +2
Lines 25048 25522 +474
==========================================
+ Hits 20535 20907 +372
- Misses 4513 4615 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3ed1207
to
ac0537a
Compare
- move CodecMetadataOptions - make `array::codec::{[metadata_]options}` private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-changes
The PR has API changes
compatibility
Related to ecosystem compatibility
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive refactor, but should not be particularly impactful to users besides codec metadata moving to a new module.
zarrs_metadata
codec
modulezarrs_metadata
no longer distinguishes Zarr V2/V3 codecs within thev2
/v3
moduleszarrs
zfpy
codec metadata (unmergingzfpy
/zfp
)write_header
fromzfp
codec configuration (sincezfpy
is now separate)FillValueMetadataV3
to support arbitrary fill value metadata for ZEP0009zarrs
vlen-utf8
/vlen-bytes
instead of experimentalvlen
codec
name handling andCodecTraits
in alignment with ZEP0009 and thezarr-extensions
repositoryzarrs.
prefix (ornumcodecs.
if fully compatible) instead of a URLCloses #116
Closes #125