fix: the issue of the menu icon not being vertical center #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, @ShiinaKin ，我将 另外，由于改变了父元素的 |
|
seems good, 符合预期 |
ruibaby
requested changes
Aug 25, 2024
ruibaby
approved these changes
Sep 5, 2024
|
@LIlGG 请问这个pr还有什么问题吗，不能发正式版的话，希望先发一个rc |
最近在忙于其他项目，所以没有对主题进行维护，待此 PR 合并后再修改一些其他问题后会发正式版本。 |
什么项目 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
解决导航栏图标未能垂直居中的问题
How to test it?
测试菜单图标是否垂直居中。
测试其他所有图标是否垂直居中。
测试是否会对界面其他元素有影响。
Which issue(s) this PR fixes:
Fixes #554
Does this PR introduce a user-facing change?