Skip to content

Commit

Permalink
Naming (openWB#1946)
Browse files Browse the repository at this point in the history
* improve default names for charge, ev, cp profiles

* ammend

* flake8
  • Loading branch information
LKuemmel authored Oct 14, 2024
1 parent fea1629 commit addb228
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/control/chargepoint/chargepoint_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class CpTemplateData:
max_current_multi_phases: int = 32
max_current_single_phase: int = 32
dc_max_current: float = 435
name: str = "neues Ladepunkt-Profil"
name: str = "Ladepunkt-Profil"
disable_after_unplug: bool = False
valid_tags: List = field(default_factory=empty_list_factory)

Expand Down
8 changes: 4 additions & 4 deletions packages/control/ev.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_vehicle_default() -> dict:
return {
"charge_template": 0,
"ev_template": 0,
"name": "neues Fahrzeug",
"name": "Fahrzeug",
"info": {
"manufacturer": None,
"model": None,
Expand All @@ -48,7 +48,7 @@ def get_new_charge_template() -> dict:


def get_charge_template_default() -> dict:
ct_default = asdict(ChargeTemplateData(name="Lade-Profil"))
ct_default = asdict(ChargeTemplateData(name="Standard-Lade-Profil"))
ct_default["chargemode"]["scheduled_charging"].pop("plans")
ct_default["time_charging"].pop("plans")
return ct_default
Expand Down Expand Up @@ -127,7 +127,7 @@ def et_factory() -> Et:

@dataclass
class ChargeTemplateData:
name: str = "neues Lade-Profil"
name: str = "Lade-Profil"
prio: bool = False
load_default: bool = False
et: Et = field(default_factory=et_factory)
Expand All @@ -143,7 +143,7 @@ def charge_template_data_factory() -> ChargeTemplateData:
class EvTemplateData:
dc_min_current: int = 0
dc_max_current: int = 0
name: str = "neues Fahrzeug-Profil"
name: str = "Fahrzeug-Profil"
max_current_multi_phases: int = 16
max_phases: int = 3
phase_switch_pause: int = 2
Expand Down
3 changes: 2 additions & 1 deletion packages/helpermodules/update_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,8 @@ class UpdateConfig:
("openWB/vehicle/0/ev_template", ev.Ev(0).ev_template.et_num),
("openWB/vehicle/0/tag_id", ev.Ev(0).data.tag_id),
("openWB/vehicle/0/get/soc", ev.Ev(0).data.get.soc),
("openWB/vehicle/template/ev_template/0", asdict(ev.EvTemplateData(name="Fahrzeug-Profil", min_current=10))),
("openWB/vehicle/template/ev_template/0", asdict(ev.EvTemplateData(name="Standard-Fahrzeug-Profil",
min_current=10))),
("openWB/vehicle/template/charge_template/0", ev.get_charge_template_default()),
("openWB/general/charge_log_data_config", get_default_charge_log_columns()),
("openWB/general/chargemode_config/instant_charging/phases_to_use", 3),
Expand Down

0 comments on commit addb228

Please sign in to comment.