New plots #11
Merged
New plots #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s they will require much more refactoring
…unctionalities within ssapy.
…r in utils.py where they initially were
…ted if user runs test_plots.py
aperloff
requested changes
Jul 22, 2024
There was a problem hiding this comment.
In general, you need to add docstrings to just about every function. Also there are large portions of plotUtils.py and utils.py where I'm not sure what you changed vs reordered vs removed. I'm trusting somewhat that you did your due diligence and didn't remove any features.
SuperdoerTrav
commented
Jul 23, 2024
aperloff
requested changes
Jul 25, 2024
aperloff
requested changes
Jul 25, 2024
aperloff
approved these changes
Jul 25, 2024
aperloff
pushed a commit
that referenced
this pull request
Jan 13, 2025
* new file to handle coordinate conversions
* moved most of the coordinate functions to .coordinates, some remain as they will require much more refactoring
* added several functions for use in plotUtils
* improved the brightness functions and added a gamma angle calculation
* updated the calculate_orbital_elements function
* added keplerian orbital element plots
* simply.py is a useful file to add functions that combine many other functionalities within ssapy.
* added points_on_circle for use in simply.py
* added ipython module for interactive plots
* added imageio for generation of gifs.
* added tqdm for progress bars
* added faster io functions and updated old io functions added by me
* added functions to calculate the position of lagrange points
* removed due to circular import conflicts, coordinates are all together in utils.py where they initially were
* added many more coordinate conversions useful for plotting
* added a gif writing function
* added built in plot to rotate_vector - used for validation
* fixed remaining circular imports
* cleaned up the get_times function, added weeks as a unit
* added doc string to ssapy_orbit()
* added plot_path as optional input to rotate_vector()
* added simply.py which will contain simplified functions for using ssapy
* adding a testing plot testing function
* changed the output of ssapy_orbit() to always give back the time array used.
* changed save directory of test plots
* added an ignore for the ssapy_test_plots/ folder which will be generated if user runs test_plots.py
* added docstrings to all plot functions
* added doc strings to all new functions
* added doc strings
* changed lagrange_point_lunar_frame() doc string
* more doc strings
* added doc strings
* added / after {save_folder}
* empty line at end
* doc string to DRO()
* new line added
* mentioned Kelerian in the doc string
* file_exists renamed
* renamed getAngle and moved get_angle to utils.py where a copy was already.
* renamed file_exists
* modified save_plot to accept any extension
* renamed write gif to save_animated_gif
* removed a comment
* removed get_angle()
* changed doc strings to lagrange point functions
* changed some function names that were changed in .utils and .compute
* merged make_black and make_white to set_color_theme
* renamed groundTrackPlot and added Keplerian to several dot strings
* drawmoon and drawearth renamed
* standardized npload and npsave and pload psave
* more renamed and changes
* lunar decapitalized
* bool instantly returned in exists
* index added to sortbynum to allow user to chose which number to sort by
* sortbynum renamed to _sortbynum
---------
Co-authored-by: yeager7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new plots to ssapy, also corrected a lot of the previous plotting functions.
orbit_plot handles many orbital frames for visualizing ssapy orbits.
groundTrackplot provides Earth maps of ssapy orbits
globeplot will create a 3d render of the Earth with a ssapy orbit.
koe_plot will plot the Keplerian orbital elements of a ssapy orbit.
Many supporting functions were required to be added for the plots. They exist in compute.py utils.py mainly.
Some of the IO functions were updated to handle more error types and do properly read csv delimiters.
New compute functions for calculating the positions of the Earth-Moon Lagrange points were added.