Enable compilation without the coq shim on Rocq 9.0 #771
+923
−849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proux01
force-pushed
the
rocq
branch
7 times, most recently
from
c469a67 to
49df0e1
Compare
|
Are you sure we need the META files for plugins? I suspect they are a leftover from coq_makefile |
|
Apparently you're right, let's CI confirm |
gares
reviewed
Feb 11, 2025
gares
approved these changes
Feb 11, 2025
|
Looks good, just a nit in case I decide to add a bin/ directory or the like |
|
CI seems finally happy. This ends up being essentially a coq-elpi -> rocq-elpi renaming. |
|
Thanks, CI green \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By reusing the with-rocq-wrap.sh script from Stdlib.
This enables to easily compile HB and mathcomp without the coq compatibility shim with Rocq 9.0+rc1.
Unfortunately we don't yet have the infrastructure to ensure this works in CI (should land soon NixOS/nixpkgs#377439 ), so only tested locally and by Docker CI for now.
TODO: