Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of work on new systematic factory design #471

Merged
merged 60 commits into from
Jan 7, 2025
Merged

Conversation

marcpaterno
Copy link
Collaborator

@marcpaterno marcpaterno commented Nov 8, 2024

Description

Redesign of factories for creation of systematics. This makes the factories more flexible in that the nature of the measurement to which the systematic will be applied partially determines what kind of systematic will be created.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (4efc44a) to head (54579e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage    99.9%   100.0%           
=======================================
  Files          54       54           
  Lines        4163     4167    +4     
=======================================
+ Hits         4160     4167    +7     
+ Misses          3        0    -3     
Files with missing lines Coverage Δ
firecrown/ccl_factory.py 100.0% <100.0%> (ø)
firecrown/connector/numcosmo/numcosmo.py 100.0% <100.0%> (+0.2%) ⬆️
firecrown/data_functions.py 100.0% <100.0%> (ø)
firecrown/likelihood/number_counts.py 100.0% <100.0%> (+0.5%) ⬆️
firecrown/likelihood/source.py 100.0% <100.0%> (ø)
firecrown/likelihood/two_point.py 100.0% <100.0%> (+0.4%) ⬆️
firecrown/parameters.py 100.0% <100.0%> (ø)
firecrown/updatable.py 100.0% <100.0%> (ø)

@marcpaterno marcpaterno changed the title Start of work on new systematic factory desgin Start of work on new systematic factory design Dec 11, 2024
@marcpaterno marcpaterno requested a review from vitenti January 7, 2025 19:33
@marcpaterno marcpaterno marked this pull request as ready for review January 7, 2025 19:33
@marcpaterno marcpaterno merged commit 4209e23 into master Jan 7, 2025
9 checks passed
@marcpaterno marcpaterno deleted the better_factories branch January 7, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants