Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch coverage #482

Merged
merged 27 commits into from
Jan 31, 2025
Merged

Fix branch coverage #482

merged 27 commits into from
Jan 31, 2025

Conversation

marcpaterno
Copy link
Collaborator

@marcpaterno marcpaterno commented Jan 17, 2025

Description

This PR provides commits to improve the branch coverage of the test suite.
It also activates the pytest measurement of branch coverage.

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Refactoring

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested a review from vitenti January 17, 2025 23:04
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (8d443c2) to head (d720675).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          54       55    +1     
  Lines        4167     4203   +36     
=======================================
+ Hits         4167     4203   +36     
Files with missing lines Coverage Δ
firecrown/ccl_factory.py 100.0% <100.0%> (ø)
firecrown/connector/cobaya/likelihood.py 100.0% <ø> (ø)
firecrown/connector/cosmosis/likelihood.py 100.0% <100.0%> (ø)
firecrown/connector/mapping.py 100.0% <100.0%> (ø)
firecrown/connector/numcosmo/helpers.py 100.0% <100.0%> (ø)
firecrown/connector/numcosmo/numcosmo.py 100.0% <100.0%> (ø)
firecrown/data_functions.py 100.0% <100.0%> (ø)
firecrown/likelihood/factories.py 100.0% <100.0%> (ø)
firecrown/likelihood/two_point.py 100.0% <100.0%> (ø)
firecrown/updatable.py 100.0% <100.0%> (ø)
... and 1 more

Copy link
Collaborator Author

@marcpaterno marcpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual requests in the comments.

@marcpaterno marcpaterno marked this pull request as ready for review January 31, 2025 19:52
@marcpaterno marcpaterno merged commit 1622f3d into master Jan 31, 2025
11 checks passed
@marcpaterno marcpaterno deleted the fix_branch_coverage branch January 31, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants