Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing missing branches #488

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Testing missing branches #488

merged 5 commits into from
Feb 5, 2025

Conversation

vitenti
Copy link
Collaborator

@vitenti vitenti commented Feb 4, 2025

Description

In order to test missing branches in NumCosmo connector we:

  • Simplified numcosmo mapping.
  • Updated numcosmo tests.

Moreover, with a new version of black we got several updates in code formatting.

Type of change

  • Testing

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Updated numcosmo tests.
Ran black (new version, several updates).
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (c6e74f5) to head (561a78b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #488    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files          55       55            
  Lines        4203     4202     -1     
  Branches        0      448   +448     
========================================
- Hits         4203     4202     -1     
Files with missing lines Coverage Δ
firecrown/__init__.py 100.0% <ø> (ø)
firecrown/connector/numcosmo/helpers.py 100.0% <100.0%> (ø)
firecrown/connector/numcosmo/numcosmo.py 100.0% <100.0%> (ø)
firecrown/generators/inferred_galaxy_zdist.py 100.0% <ø> (ø)
...own/likelihood/gauss_family/statistic/statistic.py 100.0% <ø> (ø)

@vitenti vitenti merged commit da7bb3a into master Feb 5, 2025
11 checks passed
@vitenti vitenti deleted the testing_missing_branches branch February 5, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants