Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete src/rail/example_package directory #8

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

ltoribiosc
Copy link
Collaborator

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (0a970e7) to head (1d49f78).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           1        1           
  Lines         223      223           
=======================================
  Hits          222      222           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltoribiosc
Copy link
Collaborator Author

I have deleted the example template folder. I have also run the example and it works correctly.

All 6 checks worked correctly. Only codecov shows 99.5% instead of 100%. I don't know if this is normal.

Please check that everything is correct before accepting the PR.

@sschmidt23 sschmidt23 self-requested a review February 11, 2025 18:34
Copy link
Contributor

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version looks like it is now being read correctly from tagged version. I also deleted the example notebook and examples/ directory, as we don't want two versions that could get out of sync, and there is now a copy in the main RAIL repo.

@sschmidt23 sschmidt23 merged commit 7f112ae into main Feb 11, 2025
5 checks passed
@sschmidt23 sschmidt23 deleted the dnf_delete_examples branch February 11, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants