Alex/clean up #144
Draft
Alex/clean up #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indentation was flat for the most part, with several various levels of indent where code had been modified. I cleaned it with Visual Studio Code's build in C/C++ formatter I maintained the indent on the #defines between lines 21 & 25 for readability.
Reduce magic number, especial trxstate, and several register peeks and pokes. Still not perfect, but a bit better. Fix typo COSTUM -> CUSTOM, 4 instances.
Put API in code block for emphasis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested clean up
a. Some register reads and writes were using hard coded register numbers rather than the constants defined in the .h
b. trxstate used values 0, 1, 2. Replaced by named constants for the states
idle,txandrx.