Fix CI test failure (#1216)

Layr-Labs · Feb 5, 2025 · 0fdef92 · 0fdef92
1 parent 1c6a730
commit 0fdef92
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/disperser/common/v2/blobstore/dynamo_metadata_store.go b/disperser/common/v2/blobstore/dynamo_metadata_store.go
@@ -464,7 +464,7 @@ func (s *BlobMetadataStore) GetAttestationByAttestedAt(
 		return nil, errors.New("start must be less than end")
 	}
 
-	startBucket, endBucket := getAttestedAtBucketIDRange(start, end)
+	startBucket, endBucket := GetAttestedAtBucketIDRange(start, end)
 
 	result := make([]*corev2.Attestation, 0)
 	for bucket := startBucket; bucket <= endBucket; bucket++ {
@@ -1550,9 +1550,9 @@ func getRequestedAtBucketIDRange(startTime, endTime uint64) (uint64, uint64) {
 	return startBucket, endBucket
 }
 
-// getAttestedAtBucketIDRange returns the adjusted start and end bucket IDs based on
+// GetAttestedAtBucketIDRange returns the adjusted start and end bucket IDs based on
 // the allowed time range for blobs.
-func getAttestedAtBucketIDRange(startTime, endTime uint64) (uint64, uint64) {
+func GetAttestedAtBucketIDRange(startTime, endTime uint64) (uint64, uint64) {
 	now := uint64(time.Now().UnixNano())
 	oldestAllowed := now - maxBlobAgeInNano
 

diff --git a/disperser/common/v2/blobstore/dynamo_metadata_store_test.go b/disperser/common/v2/blobstore/dynamo_metadata_store_test.go
@@ -663,15 +663,19 @@ func TestBlobMetadataStoreGetAttestationByAttestedAt(t *testing.T) {
 func TestBlobMetadataStoreGetAttestationByAttestedAtPagination(t *testing.T) {
 	ctx := context.Background()
 
-	// Use a fixed "now" so all attestations will deterministically fall in just one
+	now := uint64(time.Now().UnixNano())
+	firstBatchTs := now - uint64(5*time.Minute.Nanoseconds())
+	// Adjust "now" so all attestations will deterministically fall in just one
 	// bucket.
-	timestamp := "2025-01-21T15:04:05Z"
-	parsedTime, err := time.Parse(time.RFC3339, timestamp)
-	require.NoError(t, err)
-	now := uint64(parsedTime.UnixNano())
+	startBucket, endBucket := blobstore.GetAttestedAtBucketIDRange(firstBatchTs-1, now)
+	if startBucket < endBucket {
+		now -= uint64(25 * time.Hour.Nanoseconds())
+		firstBatchTs = now - uint64(5*time.Minute.Nanoseconds())
+	}
+	startBucket, endBucket = blobstore.GetAttestedAtBucketIDRange(firstBatchTs-1, now)
+	require.Equal(t, startBucket, endBucket)
 
 	numBatches := 240
-	firstBatchTs := now - uint64(5*time.Minute.Nanoseconds())
 	nanoSecsPerBatch := uint64(time.Second.Nanoseconds()) // 1 batch per second
 
 	// Create attestations for testing