Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused OnlySlasher error #376

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

neutiyoo
Copy link

@neutiyoo neutiyoo commented Jan 30, 2025

Overview

This pull request makes a small but important update to the IServiceManager.sol file, specifically within the IServiceManagerErrors interface. It removes the OnlySlasher error definition to resolve a conflict caused by having the same error identifier in another interface.

Error Details

Error (9097): Identifier already declared.
  --> lib/eigenlayer-middleware/src/interfaces/IServiceManager.sol:23:5:
   |
23 |     error OnlySlasher();
   |     ^^^^^^^^^^^^^^^^^^^^

This error indicates that the OnlySlasher identifier has been declared more than once across the inherited interfaces, which is not permissible in Solidity.

Resolution

The duplication occurs because IServiceManagerErrors and ISlasherErrors both declare the OnlySlasher error. To resolve this, we can remove the declaration from IServiceManagerErrors.

@ypatil12 ypatil12 merged commit eef70d9 into Layr-Labs:test/slashing-release Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants