Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

Issue #42 - Code for "Required" option #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacklawry
Copy link

Code for "Required" option by Tom Glen
"LeBlender Editor Property Validation #42"
(#42)

@Nasmar
Copy link

Nasmar commented Jun 19, 2018

I've tried to implement this. It works as intended, however theres a problem with validation on multiple items.

In parameterconfig.controller.js.

When validating on $scope.isValid() it uses _.every with a function which doesn't iterate over all the items and as it returns isValid on its own, _.every is hardly needed. It only validate the first item and when validated it returns true and the code runs $scope.submit afterwards, so the second item is never validated.

Replacing _.every with _.forEach makes the code go through all the items.

@KasperAndersson
Copy link

@Nasmar @jacklawry What's the status here??

@jacklawry
Copy link
Author

jacklawry commented Jun 11, 2019

@KasperAndersson I am not sure to be honest now - I added this PR back at the end of 2017...

I would love to see a v8 version of Le Blender.

@Nasmar
Copy link

Nasmar commented Jun 11, 2019

@KasperAndersson I've been using this since June 19, 2018 with the modifications I mentioned.

I guess they are working on a v8 implementation instead of small fixes.

@KasperAndersson
Copy link

@jacklawry @Nasmar Ok, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants