-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 모임 생성참여 구현 #5
Merged
The head ref may contain hidden characters: "feat/#3-\uBAA8\uC784-\uC0DD\uC131\uCC38\uC5EC-\uAD6C\uD604"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokjun01
added a commit
that referenced
this pull request
Jan 2, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 2, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 2, 2025
jj0526
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 ~
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
seokjun01
added a commit
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
모임에 관련된 기본적인 기능 구현을 완료했습니다. (모임 생성, 참여, 모임 목록, 상세 조회)
같은 모임이지만 모임에 따라 필요한 정보가 달라 상속을 이용했습니다.
밥,술 모임은
OfflineMeeting
, 배달 모임은DeliveryMeeting
으로 명시했으며@Inheritance(strategy = InheritanceType.JOINED))
테이블 전략을 사용했습니다.모임을 생성하면, Meeting 테이블과 각각 종류에 따른 테이블에 정보가 삽입되며, Meeting 테이블에선
DTYPE
컬럼을 통해 어느 종류의 모임인지 확인 할 수 있습니다.모임 생성시
@Valid
어노테이션을 통해 유효성 검증을 진행하도록 구현했습니다.발생할 수 있는 예외에 대해 모두 예외처리를 구현했으나 놓친 부분 찾아서 알려주시면 감사드리겠습니다.
현재 S3 버킷이 연동되어있지 않아 이미지에 관련된 부분은 모두 제외했습니다.
추후 Batch, Scheduler 등을 통한 일정 기간 후 모임 삭제, 정원이 1명 남은 상황에서 동시에 모임에 참여할 시 발생 할 수 있는 동시성 문제 등을 해결할 예정입니다.
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
📣 To Reviewers
현재 회원 관련된 부분이 완성되지않아 작성한 API들에 대한 테스트가 이루어지지 않았습니다...
추후 완성되면 테스트 진행 후 문제 발생 되는 부분에 대해 수정하도록 하겠습니다.