Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehs208
requested changes
Jan 2, 2025
src/main/java/com/example/eatmate/app/domain/member/service/MemberService.java
Outdated
Show resolved
Hide resolved
ehs208
requested changes
Jan 2, 2025
src/main/java/com/example/eatmate/app/domain/member/dto/MemberSignUpRequestDto.java
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/member/dto/MemberSignUpRequestDto.java
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/member/dto/MemberSignUpRequestDto.java
Show resolved
Hide resolved
dyk-im
approved these changes
Jan 3, 2025
Closed
3 tasks
seokjun01
force-pushed
the
fix/#5-회원가입-로그인-로직-오류수정
branch
from
71736b9 to
a187e9c
Compare
jj0526
approved these changes
Jan 3, 2025
| private final JwtService jwtService; | ||
|
|
||
| // 회원 가입 완료시 , 기본 값에서 사용자 입력값으로 업데이트 해주는 메소드 | ||
| public Void completeRegistration(MemberSignUpRequestDto signUpRequestDto, UserDetails userDetails) { |
There was a problem hiding this comment.
void와 Void 중에서 보통 void를 사용하는 거로 알고있는데 특별히 Void를 쓴 이유가 있나요?
There was a problem hiding this comment.
api 설계하면서 , 메서드 리팩토링하면서 임시로 일관성 유지를 위해 작성하였습니다!
추후에 프론트 작업자분과 이야기해보고 변경사항 생길 수 있는 부분입니다!
| // 사용자 Role 확인 | ||
| if (oAuth2User.getRole() == Role.GUEST) { | ||
| log.info("회원가입이 필요한 사용자입니다. 회원가입 페이지로 이동."); | ||
| handleGuestUser(response, oAuth2User); |
There was a problem hiding this comment.
handleGuestUser()로 따로 메소드화 하신거 좋습니다!
ehs208
requested changes
Jan 3, 2025
src/main/java/com/example/eatmate/app/domain/member/dto/MemberSignUpRequestDto.java
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/member/service/MemberService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/member/service/MemberService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/member/service/MemberService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
이슈에 작성된 대로 토큰 인증이 안됨, 회원가입 시 , 사용자 정보가 update안됨을 수정하였습니다.
OAuthLoginSuccessHandler 같은 경우 권한(Role)에 따라 메소드가 실행되며, 리다이렉트 경로가 다르게 지정됩니다.
구글 로그인의 경우, 이메일은 OAuth2 인증 과정에서 구글이 제공하는 사용자 정보로부터 추출되어 Spring Security의 UserDetails의 username으로 사용됩니다.
따라서 기존의 Dto의 email 필드가 요구사항에 맞지 않다고 판단되어 삭제하였습니다.
피드백 주시면 바로 반영하겠습니다.
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
📣 To Reviewers