Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll guides menu independently #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

scroll guides menu independently #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/inline-aside-style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ aside {
flex-direction: column;
justify-content: flex-start;
min-width: 30ch;
overflow-y: auto;
}

aside .title {
Expand Down Expand Up @@ -67,5 +66,6 @@ aside details a {
border-inline-end: 1px solid var(--c-border);
width: max-content;
height: 100%;
overflow-y: scroll;
}
}
12 changes: 11 additions & 1 deletion _includes/inline-style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ main *, .hero * {

body {
background-color: var(--c-bg);
min-height: 100vh;
height: 100vh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like this will have the effect that the footer will always be on screen? instead of being off screen on long pages?

display: grid;
overflow-y: scroll;
grid-template-rows: var(--header-height) min-content auto auto min-content;
grid-template-columns: 1fr;
grid-template-areas: "header" "hero" "main" "aside" "footer";
Expand Down Expand Up @@ -142,6 +143,7 @@ main :is(h2, h3, h4, h5, h6) a:hover::before {

@media screen and (min-width: 800px) {
body {
overflow-y: hidden;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels like a bad idea, why hide it?

grid-template-columns: min-content 8fr;
grid-template-rows: 4rem min-content auto min-content;
grid-template-areas: "header header" "hero hero" "aside main" "footer footer";
Expand Down Expand Up @@ -328,6 +330,10 @@ header nav details a {
border-block-end: 1px solid var(--c-border);
padding: 1rem;
}

main {
overflow-y: scroll;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer auto, scroll will always render the scroll bar even if it's not needed

}
}

main {
Expand Down Expand Up @@ -379,6 +385,10 @@ footer div a:not([rel*=license]), footer div .copyright {
}

@media screen and (min-width: 800px) {
footer {
position: sticky;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using position: sticky without an inset (top/bottom/left/right) feels odd, it's got no place to stick to. what's the desired effect?

}

footer div {
line-height: 1.5;
}
Expand Down
4 changes: 2 additions & 2 deletions _layouts/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
<html lang="en">
{%- include head.html with_hero=true -%}

<body>
<body style="overflow-y: scroll;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style="" really shouldn't be used, put it in the appropriate <style> tag

{%- include nav.html -%}

{%- include hero.html -%}

<main id="main">
<main id="main" style="overflow-y: visible;">
{%- include article.html article=site.posts.first -%}
</main>

Expand Down