Fix AttributeError in BinaryReader Destructor Due to Non-Existent _prepare_thread Attribute
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod) of the BinaryReader class attempts to access a non-existent attribute _prepare_thread, resulting in an AttributeError exception.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves an issue in the
BinaryReaderclass where executing the destructor (__del__method) attempts to access a non-existent attribute_prepare_thread, resulting in anAttributeError. This change ensures that the destructor checks for the existence of_prepare_threadbefore attempting to access it, thereby preventing errors during object cleanup.