Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change S3Client to use user-provided storage_options even in Studio #415

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Change S3Client to use user-provided storage_options even in Studio #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/litdata/streaming/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _create_client(self) -> None:
os.getenv("AWS_SHARED_CREDENTIALS_FILE") == os.getenv("AWS_CONFIG_FILE") == "/.credentials/.aws_credentials"
)

if has_shared_credentials_file or not _IS_IN_STUDIO:
if has_shared_credentials_file or not _IS_IN_STUDIO or self._storage_options:
bhimrazy marked this conversation as resolved.
Show resolved Hide resolved
self._client = boto3.client(
"s3",
**{
Expand Down
Loading