Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: prefer cache for missing config #2414

Merged
merged 2 commits into from
Feb 28, 2024
Merged

tests: prefer cache for missing config #2414

merged 2 commits into from
Feb 28, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 27, 2024

What does this PR do?

moving import of potentially missing packages due to configuration conflicts inside the function computing reference matric to utilize the full power of cashing; see: #2335 (comment)

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2414.org.readthedocs.build/en/2414/

@Borda Borda marked this pull request as ready for review February 27, 2024 22:46
@Borda Borda added the test / CI testing or CI label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #2414 (49e1faf) into master (c53ea94) will decrease coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2414   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         307     307           
  Lines       17352   17348    -4     
======================================
- Hits        11961   11957    -4     
  Misses       5391    5391           

@mergify mergify bot added the ready label Feb 28, 2024
@Borda Borda merged commit a8c11b4 into master Feb 28, 2024
65 of 68 checks passed
@Borda Borda deleted the tests/ref branch February 28, 2024 09:24
Borda added a commit that referenced this pull request Mar 16, 2024
move import inside ref metric

(cherry picked from commit a8c11b4)
Borda added a commit that referenced this pull request Mar 18, 2024
move import inside ref metric

(cherry picked from commit a8c11b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants