-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLIP score improvements #2978
base: master
Are you sure you want to change the base?
CLIP score improvements #2978
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2978 +/- ##
======================================
- Coverage 69% 69% -0%
======================================
Files 338 338
Lines 19436 19464 +28
======================================
+ Hits 13480 13486 +6
- Misses 5956 5978 +22 🚀 New features to boost your workflow:
|
seems like just the docs are failing with warnings? |
@Borda no there are also failing gpu tests (the test for clip score only runs on gpu, else it would take too long on cpu) |
GPU testing is fine :)
Let's try to pass it as PIL image instead? |
@Borda is there a way to get more info from azure? it is hard to debug without what is going wrong |
What does this PR do?
Fixes #2935
Fixes #2906
Fixes #2883
Add the possibility for more multimodel models that supports longer captions than the original clip model.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2978.org.readthedocs.build/en/2978/