Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 라우트 페이지간 전환 애니메이션 추가 #21

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

whitedev7773
Copy link
Collaborator

구현한 기능

  • route간 페이지 전환 애니메이션 추가 (fade-in + slide-in)

논의하고 싶은 내용

  • 선지 선택 페이지는 innerText를 변경하는 방식이라 전환 애니메이션이 적용 안됨

기타

  • 최신 리액트라서 Warning: findDom is deprecated 경고가 발생함. 그래도 작동은 잘 됨

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toothlessdev
Copy link
Member

select 페이지에서 선택지 고르면 상태가 변경되는데 이때도 애니메이션 적용되도록 수정해주시면 좋을것 같습니다!

@toothlessdev toothlessdev merged commit 8a09fcf into develop Sep 7, 2024
1 of 2 checks passed
@toothlessdev toothlessdev deleted the refacter/page-transition branch September 7, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants