Merge pull request #3329 from BsAtHome/fix_halcommand-wordsplit

Undo quoting of HALCOMMAND
LinuxCNC · Feb 7, 2025 · 78654f1 · 78654f1
2 parents cf4976f + 7da4f08
commit 78654f1
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/scripts/linuxcnc.in b/scripts/linuxcnc.in
@@ -954,7 +954,9 @@ HALCOMMAND=$($INIVAR -ini "$INIFILE" -var HALCMD -sec HAL -num $NUM 2> /dev/null
 while [ -n "$HALCOMMAND" ] ; do
     if [ -n "$HALCOMMAND" ] ; then
 	echo "Running HAL command: $HALCOMMAND" >> "$PRINT_FILE"
-	if ! $HALCMD "$HALCOMMAND" && [ -z "$DASHK" ]; then
+        # The HALCOMMAND must be word-split
+        # shellcheck disable=SC2086
+	if ! $HALCMD $HALCOMMAND && [ -z "$DASHK" ]; then
 	    echo "INI file HAL command $HALCOMMAND failed."
 	    Cleanup
 	    exit 1