try to preserve scrolling on iframe reloads if possible

SQUASHED: AUTO-COMMIT-src-components-widgets-lively-iframe.js,
LivelyKernel · Aug 21, 2024 · da64907 · da64907
1 parent cd955e0
commit da64907
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/components/widgets/lively-iframe.js b/src/components/widgets/lively-iframe.js
@@ -22,7 +22,11 @@ export default class LivelyIFrame extends Morph {
   renewIFrameListener() {
     lively.removeEventListener('iframe', this.frame, 'load')
     lively.addEventListener('iframe', this.frame, 'load', e => {
-      lively.warn('now2', this.input.value = this.frame.contentWindow.location.href)
+      try {
+        this.input.value = this.frame.contentWindow.location.href
+      } catch (e) {
+        lively.warn(e, 'changing iframe url')
+      }
     })
   }
 
@@ -33,7 +37,17 @@ export default class LivelyIFrame extends Morph {
   }
 
   updateFrame(url) {
-    this.frame.src = url;
+    const frame = this.frame;
+    let canJustReload = false
+    try {
+      canJustReload = frame.contentWindow?.location?.toString?.() === url
+    } catch (e) {}
+    if (canJustReload) {
+      // preserve scrolling
+      frame.contentWindow.location.reload(true);
+    } else {
+      frame.src = url;
+    }
   }
 
   updatePersistence(url) {