Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use single file for each command #6

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,40 +53,16 @@ jobs:
run: |
exit_code=0

# find invalid file names
for file in $(find ./commands -type f -name '*.md'); do
filename=$(basename "$file")
if [[ $filename != 'body.md' && $filename != 'footer.md' ]]; then
echo "Invalid file $file. Only body.md and footer.md are allowed" >> $GITHUB_STEP_SUMMARY
exit_code=1
fi
done

# check character count
for file in $(find ./commands -type f \( -name 'body.md' -o -name 'footer.md' \)); do
for file in $(find ./commands -type f -name '*.md'); do
echo "Checking $file"
char_count=$(wc -c <"$file")
echo "Character count: $char_count"
filename=$(basename "$file")
echo "Filename: $filename"
if [[ $filename == 'body.md' && $char_count -gt 4096 ]]; then
if [[ $char_count -gt 4096 ]]; then
echo "$file exceeds the 4096 character limit" >> $GITHUB_STEP_SUMMARY
exit_code=1
elif [[ $filename == 'footer.md' && $char_count -gt 2048 ]]; then
echo "$file exceeds the 2048 character limit"
exit_code=1
fi
if [[ $filename == 'body.md' ]]; then
dir=$(dirname "$file")
if [[ -f "$dir/footer.md" ]]; then
footer_char_count=$(wc -c <"$dir/footer.md")
total_char_count=$((char_count + footer_char_count))
if [[ $total_char_count -gt 6000 ]]; then
echo "The combined character count of $file and $dir/footer.md exceeds the 6000 character limit" \
>> $GITHUB_STEP_SUMMARY
exit_code=1
fi
fi
fi
done

Expand Down
7 changes: 7 additions & 0 deletions commands/sunshine/vban/body.md → commands/sunshine/vban.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,10 @@ configuration as follows:
Then click the stream name. The stream you made from Talkie should appear as an option.

That's it!

:information_source: **Notes**

- As Receptor does not auto-start as it is not an installed program, you may want to add it as a
Sunshine pre-launch command. Receptor will remember the last audio stream it was connected to.
- You may have to configure Windows/Game audio setting on the host to use the Microphone if you are using VB cable.
- To use Vban over the internet, you will also have to manually forward UDP Port 6980.
6 changes: 0 additions & 6 deletions commands/sunshine/vban/footer.md

This file was deleted.