Better GraphQL typings #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Brandon,
I contributed a patch a few months ago to allow editor_palette fields to be queried with GraphQL (I am possible the only person on the planet who cares if that works).
The previous patch returned the slug for the colour, which i realised is a bit lazy since GraphQL should let you decide the return format. So I updated the function to allow the user to choose which return format they would like.
Have tested this and it relies on register_graphql_acf_field_type which has been around forever so this should be a very straightforward merge, if you would care to accept.
thanks again for all your amazing plugins, use your stuff all the time! cheers