Port to 1.21 #263
Port to 1.21 #263
Conversation
|
@LordDeatHunter any timeline for when you are going to review this PR? |
| @@ -252,18 +254,6 @@ public ActionResult onUse(BlockState state, World world, BlockPos pos, PlayerEnt | |||
| } | |||
| return ActionResult.PASS; | |||
| } | |||
| if (heldItem == Items.SHEARS) { | |||
| if (topState.get(MOSSY)) { | |||
There was a problem hiding this comment.
What happened to shearing the Waystones?
| @@ -20,11 +22,9 @@ public static void register() { | |||
| return 0f; | |||
| } | |||
| if (stack.getItem() instanceof WaystoneScrollItem) { | |||
| NbtCompound tag = stack.getNbt(); | |||
| return tag == null || !tag.contains(FabricWaystones.MOD_ID) || tag.getList(FabricWaystones.MOD_ID, NbtElement.STRING_TYPE).isEmpty() ? 0 : 1; | |||
| return 1f; | |||
There was a problem hiding this comment.
Won't this always default to 1 texture, instead of 2 textures per state (1 for empty scroll, 1 for bound scroll)?
|
I left a comment last time but I guess I had to click Finish Review. |
|
Thanks for taking the time for all this. I found some bugs while testing:
Possible bugs that might've existed from before, or aren't that important:
|
|
So I fixed all of the issues except
I couldn't replicate that so I don't know where exactly is the issue. On my survival server global waystones always worked for us. |
|
I can test again later in the evening. |
I jumped from 1.20.4 to 1.21, Don't have a working version for 1.20.5-1.20.6 and I don't know how hard is it to do that.
Closes #259