Cleanup environment project

[lahm86]

Cleanup tasks for the TREnvironmentEditor project.
Part of #425.

[rr-]

I love the new syntactic sugar.

[rr-]

I don't know about you, but this variant is less readable to me than the original; if it's normal in C# world or the IDE complains that it should be coded this way, let's leave it as-is.

[lahm86]

Yeah, it's used like this in a few places across the solution, and there was a message about it here.

[rr-]

Can this be coded in a more beautiful way, with the switch only mapping T instead of the entire result?

Something such as this

EMType type = …;
Type resultType = type switch {
    EMType.MirrorModel => EMImportModelFunction,
    …,
};
return (
    typeof(JsonConvert)
    .GetMethod("DeserializeObject")
    .MakeGenericMethod(resultType)
    .Invoke(jo.ToString(), this)
);

or something similar? (Maybe there's a compile-time friendly alternative to GetMethod in 2023, too)

[lahm86]

The Newtonsoft method is as follows, but there are several overloads.

public static T? DeserializeObject<T>(string value, params JsonConverter[] converters)

The following works, but it feels too dependent on reflection and difficult to read imo.

return typeof(JsonConvert)
    .GetMethods()
    .Where(m => m.Name == nameof(JsonConvert.DeserializeObject) && m.IsGenericMethod && m.GetParameters().Length == 2)
    .First()
    .MakeGenericMethod(emType)
    .Invoke(null, new object[] { jo.ToString(), new JsonConverter[] { this } });

Another task we plan for is to move to System.Text.Json (#506) and to be honest it is this environment deserialization that will be the sticking point. What do you think about re-addressing it there? I've done a little looking into it and the JObject approach won't work out of the box anyway, so we're going to have to come up with a different parsing technique.

[rr-]

Sure, if there are plans to migrate to something else anyway, there's no use to waste time on reworking this approach.